feat(tier4_state_rviz_plugin): check for abrupt deceleration #9474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:common
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
satoshi-ota
reviewed
Nov 29, 2024
common/tier4_state_rviz_plugin/src/include/velocity_steering_factors_panel.hpp
Outdated
Show resolved
Hide resolved
satoshi-ota
reviewed
Nov 29, 2024
common/tier4_state_rviz_plugin/src/include/velocity_steering_factors_panel.hpp
Outdated
Show resolved
Hide resolved
satoshi-ota
reviewed
Nov 29, 2024
common/tier4_state_rviz_plugin/src/include/velocity_steering_factors_panel.hpp
Outdated
Show resolved
Hide resolved
satoshi-ota
reviewed
Nov 29, 2024
common/tier4_state_rviz_plugin/src/velocity_steering_factors_panel.cpp
Outdated
Show resolved
Hide resolved
mitukou1109
requested review from
h-ohta,
isamu-takagi and
KhalilSelyan
as code owners
… panel Signed-off-by: mitukou1109 <[email protected]>
Signed-off-by: mitukou1109 <[email protected]>
Signed-off-by: mitukou1109 <[email protected]>
Signed-off-by: mitukou1109 <[email protected]>
mitukou1109
force-pushed
the
feat/abrupt_deceleration_checker
branch
from
6bf3546 to
406cef1
Compare
satoshi-ota
added
the
tag:run-build-and-test-differential
isamu-takagi
approved these changes
Dec 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9474 +/- ##
==========================================
- Coverage 29.49% 29.48% -0.02%
==========================================
Files 1441 1442 +1
Lines 108590 108655 +65
Branches 41471 41477 +6
==========================================
Hits 32032 32032
- Misses 73229 73294 +65
Partials 3329 3329
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 2, 2024
…efoundation#9474) * add abrupt deceleration checking feature to velocity steering factors panel Signed-off-by: mitukou1109 <[email protected]> * use spin box instead of slider & change layout Signed-off-by: mitukou1109 <[email protected]> * set minimum input to 0.0 Signed-off-by: mitukou1109 <[email protected]> * change accent color to Freak Pink Signed-off-by: mitukou1109 <[email protected]> --------- Signed-off-by: mitukou1109 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an abrupt deceleration checking feature to
VelocitySteeringFactorsPanel.If the minimum distance required to stop under the specified jerk and acceleration limit is greater than the distance to the stop point, abrupt deceleration is detected.
How was this PR tested?
Psim
Screencast.from.2024.11.29.19.36.39.webm
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.